This repository was archived by the owner on Nov 4, 2024. It is now read-only.
fix: Fix pull_translations by using correct CLI flag for languages #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: https://developers.transifex.com/docs/using-the-client Apparently this CLI option changed from singular to plural at some point.
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 15 15
Lines 164 164
Branches 28 28
=======================================
Hits 80 80
Misses 79 79
Partials 5 5 Continue to review full report at Codecov.
|
dianekaplan
approved these changes
May 13, 2022
Contributor
There was a problem hiding this comment.
Thanks for the catch/fix!
For posterity, the corresponding error thrown by pull_translations is: flag provided but not defined: -language
example output here: https://tools-edx-jenkins.edx.org/job/translations/job/frontend-app-ecommerce-pull_translations/167/console
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://developers.transifex.com/docs/using-the-client
Apparently this CLI option changed from singular to plural at some point.
(The push job is currently broken as well, for a different reason, so this may not be sufficient to get the pull job working.)