Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

chore: Switch from edx-sphinx-theme to sphinx-book-theme #257

Conversation

xitij2000
Copy link
Contributor

The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme.
This removes references to the deprecated theme and replaces them with the new
standard theme for the platform.

See openedx/public-engineering#200

@openedx-webhooks
Copy link

openedx-webhooks commented May 25, 2023

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 25, 2023
@xitij2000 xitij2000 marked this pull request as ready for review May 29, 2023 06:58
@mphilbrick211
Copy link

Hi @xitij2000! Would you mind taking a look at resolving the branch conflicts? I'll then pass it along for review. Thanks!

The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme.
This removes references to the deprecated theme and replaces them with the new
standard theme for the platform.

See openedx/edx-sphinx-theme#184
@xitij2000 xitij2000 force-pushed the kshitij/switch-to-sphinx-book-theme branch from 9477825 to 0ca494e Compare June 1, 2023 12:43
@xitij2000
Copy link
Contributor Author

Hi @xitij2000! Would you mind taking a look at resolving the branch conflicts? I'll then pass it along for review. Thanks!

Done!

@feanil
Copy link
Contributor

feanil commented Jun 1, 2023

Looks like this repo doesn't even build docs at the moment but it's good to keep this updated.

@feanil feanil merged commit 1dc16c9 into openedx-unsupported:master Jun 1, 2023
@openedx-webhooks
Copy link

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath Agrendalath deleted the kshitij/switch-to-sphinx-book-theme branch June 1, 2023 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants