Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

docs: add local plugin dev to README #256

Merged

Conversation

connorhaugh
Copy link
Contributor

@connorhaugh connorhaugh commented May 25, 2023

This adds documentation for how users can develop with blockstore locally in devstack as a python plugin.

This adds documentation for how users can develop with blockstore locally in devstack.
@connorhaugh connorhaugh requested review from a team May 25, 2023 13:53
README.rst Show resolved Hide resolved
#. In your devstack directory, run the following commands in order:

.. code::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an assumption about virtual environments here? If using a virtual environment, should be activating it before these operations.

Copy link
Contributor Author

@connorhaugh connorhaugh May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You actually totally could do this without a venv. I know this because I accidentally did. I wouldn't recommend it though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a base assumption for working in openedx I don't feel like I need to include it.

README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved

You're probably also going to want to create a collection for using content libraries, using:

.. code::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your assumptions about the existence and state of a blockstore container prior to this point? What about now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide makes no assumptions that you ever ran blockstore as a separate service, and hence, assumes no container exists. There previously was an error which referenced such a container, but that was a copy-paste error.

README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
The Library Authoring MFE will want to know about that collection id `using a ENV variable. <https://github.com/openedx/frontend-app-library-authoring/blob/d590aa2eb54c94b39d94f2ba12a6b458082c2e5e/.env#L19>`_

Then restart Studio and the LMS (``make dev.restart-devserver.lms dev.restart-devserver.studio``).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing part of the readme is still a bit thin. What steps to follow and what to look for to confirm that a) the IDA is no longer running; b) the Django app is; and c) the Django app blockstore is running as expected.

Copy link
Contributor Author

@connorhaugh connorhaugh May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide doesn't care that you ever ran blockstore as a separate service. You could be running the blockstore service at the same time, but the waffle flag makes it such that it doesn't matter. This guide replaces blockstore as a service setup for local dev.
I added a part to direct the user to set up content libraries v2. That is how blockstore is used and the system's effectiveness can be tested.

@bszabo
Copy link
Contributor

bszabo commented May 25, 2023

There's a lint commit error that needs attention

@connorhaugh
Copy link
Contributor Author

connorhaugh commented May 26, 2023

There's a lint commit error that needs attention

I'll just squash when I merge.

@connorhaugh connorhaugh requested a review from bszabo May 26, 2023 12:45
@connorhaugh connorhaugh merged commit 226789e into master May 30, 2023
@connorhaugh connorhaugh deleted the docs-add-documentation-for-installing-local-plugin branch May 30, 2023 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants