Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix package name #216

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

aht007
Copy link
Contributor

@aht007 aht007 commented Oct 27, 2022

Description

The name blockstore is already taken on PyPI and hence the release failed. Updating the package name in this PR to resolve the issue

@aht007 aht007 requested a review from a team October 27, 2022 09:00
@aht007
Copy link
Contributor Author

aht007 commented Oct 28, 2022

As per the conversation with @nedbat the prefix should be openedx as the repo is hosted in openedX GH organization.
https://edx-internal.slack.com/archives/CG7FM3BLY/p1666881497813729?thread_ts=1666861508.868599&cid=CG7FM3BLY

@connorhaugh
Copy link
Contributor

A quick question: will this be a breaking change in places where we install blockstore (edx-platform)? How are we effectively making that transition?

@nedbat
Copy link
Contributor

nedbat commented Oct 28, 2022

blockstore is currently installed from GitHub using a pin:
https://github.com/openedx/edx-platform/blob/master/requirements/edx/github.in#L74

-e git+https://github.com/openedx/blockstore.git@1.2.1#egg=blockstore==1.2.1  # Note: Blockstore 1.2.2 is failing.

so this will not break edx-platform.

@aht007
Copy link
Contributor Author

aht007 commented Oct 31, 2022

@connorhaugh this will not break anything as we are just changing the name of PyPi distribution. The imports will still remain the same by this change. As Ned also mentioned that its installed using a pin in edx-platform so if any breaking change still makes it to the release it wouldn't affect edx-platform. Also I have followup ticket to install blockstore from PyPI in edx-platform so I will be testing the changes in the scope of that ticket as well.
Just waiting for the review now so that I can go ahead and merge and release it to PyPI.

@connorhaugh
Copy link
Contributor

@connorhaugh this will not break anything as we are just changing the name of PyPi distribution. The imports will still remain the same by this change. As Ned also mentioned that its installed using a pin in edx-platform so if any breaking change still makes it to the release it wouldn't affect edx-platform. Also I have followup ticket to install blockstore from PyPI in edx-platform so I will be testing the changes in the scope of that ticket as well. Just waiting for the review now so that I can go ahead and merge and release it to PyPI.

Ok great!

@aht007 aht007 merged commit 4f24195 into master Nov 1, 2022
@aht007 aht007 deleted the revert-215-revert-214-aht007/UPDATE-PACKAGE_NAME branch November 1, 2022 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants