feat(zfspv): try volume creation on all the nodes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
force-pushed
the
wait
branch
3 times, most recently
from
63550b4 to
e4fac6a
Compare
kmova
reviewed
Jan 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
======================================
Coverage 1.09% 1.10%
======================================
Files 11 11
Lines 912 908 -4
======================================
Hits 10 10
+ Misses 902 898 -4
Continue to review full report at Codecov.
|
pawanpraka1
force-pushed
the
wait
branch
3 times, most recently
from
4699b24 to
686b505
Compare
pawanpraka1
changed the title
pawanpraka1
added
pr/hold-merge
pawanpraka1
force-pushed
the
wait
branch
6 times, most recently
from
3a84aa7 to
7f4fbcd
Compare
kmova
reviewed
Mar 30, 2021
pawanpraka1
force-pushed
the
wait
branch
2 times, most recently
from
ceebe96 to
a7a1031
Compare
kmova
approved these changes
Apr 2, 2021
Currently controller picks one node and the node agent keeps on trying to create the volume on that node. There might not be enough space available on that node to create the volume. The controller can try on all the nodes sequentially and fail the request if volume creation fails on all the nodes which satisfies the topology contraints. Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
pvc gets bound even zfs volume creation keeps on failing on the node.
What this PR does?:
Currently scheduler returns one node and the provisioner uses that node to provision the volume. Once scheduler returns the node list in the priority order instead of returning just one node, the CSI controller can attempt the volume creation on all the nodes. Here, in this case if the volume is not created, the pvc will not be bound as the controller will wait to the volume to be ready or failed. Also, the the node agent will not reconcile for the creation of the volume, it will attempt to create once and fail if not successful. The csi provisioner will keep on requesting to create the volume in case of failure.
Depends on openebs/lib-csi#2
Known Issue?:
if volume creation request in progress and we are deleting the pvc, CSI plugin does not get the delete call and if volume creation succeeds, there will be one stale volume in the system.
Checklist:
<type>(<scope>): <subject>