fix(yaml): removing volumeLifecycleModes from the operator yaml #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
changed the title
This field was added in Kubernetes 1.16 and it informs Kubernetes about the volume modes that are supported by the driver. The default is "Persistent" if it is not used. This operator yaml will not work on k8s 1.14 and 1.15, since the driver supports those k8s version so no need to mention volumeLifecycleModes in the operator as the default is "Persistent". Signed-off-by: Pawan <pawan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 22.88% 22.88%
=======================================
Files 14 14
Lines 485 485
=======================================
Hits 111 111
Misses 373 373
Partials 1 1 Continue to review full report at Codecov.
|
kmova
approved these changes
Jul 22, 2020
|
@pawanpraka1 -- should this change be added to the openebs/charts YAML files as well? |
|
yes @kmova , I will raise the same PR in the charts repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #163
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
This field was added in Kubernetes 1.16 and it informs Kubernetes about
the volume modes that are supported by the driver. The default is
"Persistent" if it is not used.
What this PR does?:
This operator yaml will not work on k8s 1.14 and 1.15, since the driver supports
those k8s version so no need to mention volumeLifecycleModes in the operator as
the default is "Persistent". We broke this in #85.
Checklist:
<type>(<scope>): <subject>