fix(util): fixing static memleak in version-info macro #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsavitskiy
force-pushed
the
feature/fix-mem-leak
branch
from
98a7f08 to
f4cf93f
Compare
| static mut BUF: Vec<u8> = Vec::new(); | ||
| let s = String::from($crate::version_info!()); | ||
| unsafe { | ||
| BUF.resize(s.len(), 0); |
There was a problem hiding this comment.
Wouldn't a second call to this invalidate the first memory as we're resizing?
would OnceCell be more appropriate usage?
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
dsavitskiy
force-pushed
the
feature/fix-mem-leak
branch
from
f4cf93f to
a1b0cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.