Skip to content

Conversation

frasmarco
Copy link

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
This PR resolves #236 disabling lvm archiving which is enabled by default in Alpine

What this PR does?:
changes from 1 to 0 the archive setting in /etc/lvm/lvm.conf via sed in the Docker build phase

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
Verify that archive dir /etc/lvm/archive remains empty after lv provisioning

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Signed-off-by: Marco Frassinelli fras.marco@gmail.com

@tiagolobocastro
Copy link
Member

A few questions,

  1. Can this be made configurable from the helm chart?
  2. Can we set max amount of retention or something like that instead of fully disabling?

@mhkarimi1383 mhkarimi1383 mentioned this pull request Sep 19, 2024
@dsharma-dc
Copy link
Contributor

@frasmarco Could you consider the earlier comments and see if you'll be able to make this configurable by using params like retain_days , max_archives etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lvm archive eats lot of space when creating thousands of volumes

3 participants