This repository has been archived by the owner on May 8, 2024. It is now read-only.
[stable/openebs]: update openebs charts to 2.4.0 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
akhilerm
commented
Dec 10, 2020
Comment on lines
+32
to
+35
| {{- with .Values.imagePullSecrets }} | ||
| imagePullSecrets: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
@sonasingh46 @prateekpandey14 Should we use with or if.
- We need to be consistent across all the repos.
- We need to be consistent in the templates. For some fields
withand for someifare used.
There was a problem hiding this comment.
my two cents. You should stay with Helm defaults. If you do helm create test.. you will see that in the deployment file
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
...
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.affinity }}
affinity:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.tolerations }}
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
There was a problem hiding this comment.
great. Then I will follow this pattern,
|
will it include cstor-operator too ? |
@survivant this is the PR for cstor-operator charts |
45 tasks
- update chart version - update values.yaml - update README Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
- update chart version - update values.yaml - update README Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
- update chart version - update values.yaml - update README Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
approved these changes
Dec 15, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Special notes for your reviewer:
The PR should be squashed and merged.
Checklist
[stable/openebs])