fix(sysfs): trim newline while parsing sysfs files #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysfs files like dm/uuid etc are sometimes suffixed by a newline character which need to be trimmed off for correct parsing, else it will result in incorrect device type being detected Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
Codecov Report
@@ Coverage Diff @@
## develop #666 +/- ##
===========================================
+ Coverage 44.78% 45.06% +0.27%
===========================================
Files 79 79
Lines 3970 3970
===========================================
+ Hits 1778 1789 +11
+ Misses 2024 2016 -8
+ Partials 168 165 -3
Continue to review full report at Codecov.
|
akhilerm
requested review from
Ab-hishek,
RealHarshThakur,
kmova,
shubham14bajpai and
z0marlin
shubham14bajpai
approved these changes
Dec 28, 2021
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Dec 28, 2021
sysfs files like dm/uuid etc are sometimes suffixed by a newline character which need to be trimmed off for correct parsing, else it will result in incorrect device type being detected Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
This was referenced Dec 28, 2021
akhilerm
added a commit
that referenced
this pull request
Dec 28, 2021
sysfs files like dm/uuid etc are sometimes suffixed by a newline character which need to be trimmed off for correct parsing, else it will result in incorrect device type being detected Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@datacore.com
Why is this PR required? What issue does it fix?:
sysfs files like
dm/uuidetc are sometimes suffixed by a newlinecharacter which need to be trimmed off for correct parsing, else
it will result in incorrect device type being detected
What this PR does?:
trim the newline suffix while reading from sysfs
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>