-
Notifications
You must be signed in to change notification settings - Fork 115
fix(cleaner): fix disk partition cannot be released after creating lvm #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cleaner): fix disk partition cannot be released after creating lvm #662
Conversation
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
c108cbd to
b7727e5
Compare
…-disk-manager into fix-parition-lvm Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
b7727e5 to
bad1de0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #662 +/- ##
===========================================
- Coverage 45.10% 45.02% -0.08%
===========================================
Files 79 79
Lines 3971 3971
===========================================
- Hits 1791 1788 -3
- Misses 2009 2017 +8
+ Partials 171 166 -5
Continue to review full report at Codecov.
|
|
@liuminjian Can you raise the corresponding PR in linux-utils repository also to update with device-mapper packages? |
|
akhilerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: have a doubt on removing volume groups from the device.
akhilerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request template
Why is this PR required? What issue does it fix?:
I create a virtual machine to mount the disk, partition the disk, then use the partition to create vg, create lv, format lv, and then mount lv to the directory. When I delete the virtual machine and release the disk, the cleaner job will report an error device busy. The operation is as follows.
Does this PR require any upgrade changes?:
need to update linux-utils add lvm2 and device-mapper
liuminjian/linux-utils@90a4942