Skip to content

Conversation

@liuminjian
Copy link
Contributor

Pull Request template

Why is this PR required? What issue does it fix?:

I create a virtual machine to mount the disk, partition the disk, then use the partition to create vg, create lv, format lv, and then mount lv to the directory. When I delete the virtual machine and release the disk, the cleaner job will report an error device busy. The operation is as follows.

  1. create a vm with a block device /dev/vdb
  2. create a disk partiton /dev/vdb1
  3. vgcreate vg1 /dev/vdb1
  4. lvcreate -L 5G -n lv1 vg1
  5. mkfs.ext4 /dev/vg1/lv1
  6. mount /dev/vg1/lv1 /root/test
  7. delete vm and release block device

QQ20211222-190930@2x

Does this PR require any upgrade changes?:
need to update linux-utils add lvm2 and device-mapper
liuminjian/linux-utils@90a4942

…-disk-manager into fix-parition-lvm

Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #662 (b7727e5) into develop (7c64d44) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head b7727e5 differs from pull request most recent head bad1de0. Consider uploading reports for the commit bad1de0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
- Coverage    45.10%   45.02%   -0.08%     
===========================================
  Files           79       79              
  Lines         3971     3971              
===========================================
- Hits          1791     1788       -3     
- Misses        2009     2017       +8     
+ Partials       171      166       -5     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/addhandler.go 68.95% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c64d44...bad1de0. Read the comment docs.

@akhilerm akhilerm self-requested a review December 23, 2021 08:28
@akhilerm
Copy link
Contributor

@liuminjian Can you raise the corresponding PR in linux-utils repository also to update with device-mapper packages?

@liuminjian
Copy link
Contributor Author

@liuminjian Can you raise the corresponding PR in linux-utils repository also to update with device-mapper packages?
ok openebs/linux-utils#22

Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: have a doubt on removing volume groups from the device.

Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm merged commit 9f40337 into openebs-archive:develop Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants