Skip to content

Conversation

@akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Dec 13, 2021

Why is this PR required? What issue does it fix?:
udev is not able to fetch the partition entry uuid in CentOS 7, since PARTUUID is not supported in libblkid 2.23.

What this PR does?:
Uses the libblkid from the base container to fetch the partition entry UUID, if it was not filled in by udev

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

@akhilerm
Copy link
Contributor Author

@cospotato Can you help with reviews on this PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #657 (3c33f2e) into develop (498c632) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #657      +/-   ##
===========================================
- Coverage    45.04%   44.79%   -0.25%     
===========================================
  Files           79       79              
  Lines         3969     3971       +2     
===========================================
- Hits          1788     1779       -9     
- Misses        2010     2024      +14     
+ Partials       171      168       -3     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/blkidprobe.go 0.00% <0.00%> (ø)
cmd/ndm_daemonset/probe/addhandler.go 67.97% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498c632...3c33f2e. Read the comment docs.

Signed-off-by: Akhil Mohan <akhil.mohan@datacore.com>
@akhilerm akhilerm force-pushed the fix-centos-part-uuid branch from 4968bfe to 3c33f2e Compare December 13, 2021 06:31
@cospotato
Copy link
Contributor

@akhilerm OK. It's my pleasure.

Copy link
Contributor

@cospotato cospotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@z0marlin z0marlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z0marlin z0marlin merged commit 7c64d44 into openebs-archive:develop Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find any block devices when running command "kubectl get bd -n openebs"

5 participants