Skip to content

Conversation

@akhilerm
Copy link
Contributor

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

What this PR does?:
mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #649 (f64f519) into develop (4b09fda) will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #649      +/-   ##
===========================================
+ Coverage    45.99%   46.30%   +0.31%     
===========================================
  Files           78       78              
  Lines         3820     3820              
===========================================
+ Hits          1757     1769      +12     
+ Misses        1905     1890      -15     
- Partials       158      161       +3     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/addhandler.go 73.37% <0.00%> (+2.04%) ⬆️
cmd/ndm_daemonset/probe/udevprobe.go 49.01% <0.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b308a...f64f519. Read the comment docs.

@kmova kmova merged commit 9fe3968 into openebs-archive:develop Sep 21, 2021
@akhilerm akhilerm deleted the fix-cleanup-job branch September 21, 2021 04:41
z0marlin pushed a commit to akhilerm/node-disk-manager that referenced this pull request Sep 22, 2021
mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Sep 24, 2021
mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova pushed a commit that referenced this pull request Sep 24, 2021
mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants