fix(client): fix client Get call done in BD update #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilerm
requested review from
RealHarshThakur,
kmova,
niladrih and
z0marlin
Contributor
|
Unit tests are failing due to this? |
Codecov Report
@@ Coverage Diff @@
## develop #648 +/- ##
===========================================
- Coverage 45.10% 44.82% -0.29%
===========================================
Files 79 79
Lines 3964 3969 +5
===========================================
- Hits 1788 1779 -9
- Misses 2011 2022 +11
- Partials 165 168 +3
Continue to review full report at Codecov.
|
Contributor
Author
|
Fixed the unit tests @RealHarshThakur |
z0marlin
force-pushed
the
fix-get-call
branch
from
153cc7d to
04548ea
Compare
akhilerm
force-pushed
the
fix-get-call
branch
2 times, most recently
from
9febf18 to
25119d5
Compare
use empty object instead of deepcopy object in Get() call. This is done so that empty fields returned from API server are not filled in from the deepcopy object Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
force-pushed
the
fix-get-call
branch
from
25119d5 to
db9a73d
Compare
z0marlin
reviewed
Dec 6, 2021
Use logging level 4
z0marlin
reviewed
Dec 6, 2021
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
z0marlin
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
What this PR does?:
use empty object instead of deepcopy object in Get() call. This
is done so that empty fields returned from API server are not filled
in from the deepcopy object
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>