Display output using template #68
Conversation
utkarshmani1997
commented
Jul 26, 2017
utkarshmani1997
commented
- Local variable naming as prescribed by the Golang community.
- Displays output using Template.
| data, err := json.MarshalIndent(annotation, "", "\t") | ||
|
|
||
| // Printing using template | ||
| tmpl, err := template.New("test").Parse("IQN : {{.IQN}}\nVolume : {{.Volume}}\nPortal : {{.Portal}}\nSize : {{.Size}}") |
There was a problem hiding this comment.
Use typed string constant for the string used in template.
Eventually this typed string will be used to define many more templates.
| panic(err) | ||
| } | ||
|
|
||
| os.Stdout.Write(data) | ||
|
|
||
| // Printing in tabular form | ||
| q := tabwriter.NewWriter(os.Stdout, minwidth, maxwidth, padding, ' ', tabwriter.AlignRight|tabwriter.Debug) | ||
|
|
||
| fmt.Fprintf(q, "\n\nReplica\tStatus\tDataUpdateIndex\t\n") |
There was a problem hiding this comment.
Why are we not using template feature vs. fmt.Fprintf ?
There was a problem hiding this comment.
This is required to print the output in tabular format (syntax of text/tabwriter package) as suggested by @prateekpandey14.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 14.04% 13.98% -0.06%
==========================================
Files 31 31
Lines 5085 5083 -2
==========================================
- Hits 714 711 -3
Misses 4329 4329
- Partials 42 43 +1
Continue to review full report at Codecov.
|
|
the changes are merged in #83 .Closing this PR |
