Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Release to 1.0.2 #581

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Bump Release to 1.0.2 #581

merged 2 commits into from
Nov 5, 2023

Conversation

joshua-oss
Copy link
Contributor

  • Update snsql dependency to 1.0.2 to take advantage of bug fix in approx_bounds
  • Fix bug where MST synthesizer would raise warning but attempt to keep running when mbi not installed
  • Update documentation to highlight mbi dependency

Addresses #573

@joshua-oss joshua-oss merged commit 0b92809 into main Nov 5, 2023
3 checks passed
@ocolluphid
Copy link

@joshua-oss question re. this update to the MST code: does this mean that the tutorial here regarding domain use is no longer up to date and we should defer to this: https://docs.smartnoise.org/synth/synthesizers/mst.html

@joshua-oss
Copy link
Contributor Author

Yes, that code sample still should work (we haven't done anything to disable it) but it's better to use the common pattern used across all the synthesizers. Note that I recently discovered an issue where MST and AIM are failing if the inferred cliques overlap in a certain order, so if you're seeing errors like "column_name is both an index and a level", it's a bug that I haven't yet tracked down.

@ocolluphid
Copy link

thanks! will defer to latest one without domain specification then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants