improve code section look #472
Conversation
1. Reduced line-height for code sections, easier to read 2. Added Droid Sans Mono for Linux desktop
There was a problem hiding this comment.
Hi @inntran, thanks a bunch for the PR. I'm completely in favor of adding more Linux-friendly fonts, and Droid Sans Mono is a good one.
I suspect we've hit an impasse on the line height, though. I think the current height helps out a lot with readability, especially on larger blocks like the Docker Compose file or response JSON, and it's very similar to the height that GitHub uses in its reviews.
Edited: I've continued staring at the screen and think that maybe we can hit a happy medium at 1.4 rather than normal. Let me know what you think.
|
I checked on my Mac, yeah the 1.4 line-height looks fine. The font-family is more important than line-height on Linux. I'll update this PR. |
|
Before this explicit line-height specification, the code section would use inherited line-height from class "main-content", which is 1.6 in this case, that explains why the code section always looked weird to me. |
|
LGTM, thanks a bunch. |
2 participants
Description of changes:
Default style from just-the-docs theme has a quite large line-height for code sections, and the font-family list only take macOS and Windows into consideration. On Linux ( RHEL 7 in my case ), Droid Sans Mono looks better.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.