This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Create a base class RCA ResourceResourceRca as a generic resource type RCA. Add HighCpuRca to collect total cpu usage #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditac
reviewed
Mar 20, 2020
| private final int rcaPeriod; | ||
| private int counter; | ||
| private final ResourceType resourceType; | ||
| private double threshold; |
There was a problem hiding this comment.
Can we make this final so that its threadsafe?
There was a problem hiding this comment.
I have changed those variables to volatile to make them thread safe
ditac
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The GenericResourceRca is a base type RCA class which collect aggregated metric from a certain resource type and calculated its averaged sum by using a sliding window.
The HighCpuRca derives from the TotalResourceRca to calculate the cpu usage of its node and list the top k consumers.
Add a unit test for this rca class
Tests:
tested on dev stack
Code coverage percentage for this patch:
82%
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.