This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve log message when we cannot get anomaly result #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A connection request to a threshold model node can be rejected. Previously, we count exceptions due to connection problem as "unexpected". But we should not as this might happen when the cluster is unstable. This PR fixes the log message. Testing: - unit and integration test pass
yizheliu-amazon
approved these changes
Mar 9, 2020
ylwu-amzn
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection request to a threshold model node can be rejected. Previously, we count exceptions due to connection problem as "unexpected". But we should not as this might happen when the cluster is unstable. This PR fixes the log message.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.