This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add threadpool prefix and change threadpool name #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run AD and SQL plugin together, ES fails to start with registering a setting twice error. AD's threadpool setting prefix is null. Since SQL plugin uses null as well, we would have a register setting conflict because we cannot register setting [null.size] twice. The fix is to give our threadpool a setting name prefix instead of null Also, this threadpool would be used by other components besides AD job. Rename it to make it not ad job specific. Testing done: - run all unit and integration tests
ylwu-amzn
reviewed
Mar 6, 2020
| AD_JOB_THEAD_POOL_QUEUE_SIZE, | ||
| null | ||
| AD_THEAD_POOL_QUEUE_SIZE, | ||
| "opendistro.ad.ad_thread_pool" |
There was a problem hiding this comment.
How about we use "opendistro.ad."+ AD_THREAD_POOL_NAME ? So we can know exactly which threadpool it maps to.
jngz-es
approved these changes
Mar 6, 2020
ylwu-amzn
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run AD and SQL plugin together, ES fails to start with registering a setting twice error. AD's threadpool setting prefix is null. Since SQL plugin uses null as well, we would have a register setting conflict because we cannot register setting [null.size] twice. The fix is to give our threadpool a setting name prefix instead of null
Also, this threadpool would be used by other components besides AD job. Rename it to make it not ad job specific.
Testing done:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.