build artifacts for rpm, deb, zip #5
Conversation
| release = isSnapshot ? "0.1" : '1' | ||
| version = "${project.version}" - "-SNAPSHOT" | ||
|
|
||
| into '/usr/share/elasticsearch/plugins' |
There was a problem hiding this comment.
If we are missing some folder of this path, would it be generated automatically?
There was a problem hiding this comment.
All plugins will use the same path, like alerting, sql etc. So I don't think this is a problem.
| @@ -31,6 +31,10 @@ buildscript { | |||
| } | |||
There was a problem hiding this comment.
Have you tested the built artifacts on a redhat or debian machine?
There was a problem hiding this comment.
No, but I manually checked the artifacts which look having everything. The command "./gradlew buildPackages --refresh-dependencies --console=plain -Dbuild.snapshot=false" will generate all artifacts.
There was a problem hiding this comment.
To be safe, I suggest we spin up a debian or redhat host and install it there to see if AD can run properly. Otherwise, we are waiting for customers to test this for us.
| dependsOn 'assemble' | ||
| } | ||
|
|
||
| task buildPackages(type: GradleBuild) { |
There was a problem hiding this comment.
Suggestion/Question. Should the instruction on how to build be added to readme?
There was a problem hiding this comment.
Good suggestion, will add it later. By the way, is that you, Lai? I didn't realize it :)
issue #3