Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change AD indices to be hidden indices instead of system indices #398

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

kaituo
Copy link
Member

@kaituo kaituo commented Mar 10, 2021

Issue #, if available:

Description of changes:
This is a forward-port of PR 394, 395.

Testing done:

  1. Manually verified AD indices are hidden.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is a forward-port of PR 394, 395.

Testing done:
1. Manually verified AD indices are hidden.
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #398 (fa3544b) into main (0515a35) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #398   +/-   ##
=========================================
  Coverage     79.16%   79.17%           
- Complexity     2680     2682    +2     
=========================================
  Files           248      248           
  Lines         11749    11749           
  Branches       1010     1010           
=========================================
+ Hits           9301     9302    +1     
  Misses         1970     1970           
+ Partials        478      477    -1     
Flag Coverage Δ Complexity Δ
plugin 79.16% <100.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java 95.38% <ø> (-0.11%) 10.00 <0.00> (-1.00)
...sticsearch/ad/indices/AnomalyDetectionIndices.java 51.41% <100.00%> (+0.14%) 44.00 <0.00> (-1.00) ⬆️
...stroforelasticsearch/ad/AnomalyDetectorRunner.java 40.00% <0.00%> (-6.25%) 6.00% <0.00%> (-1.00%)
...on/opendistroforelasticsearch/ad/model/ADTask.java 98.12% <0.00%> (+1.56%) 68.00% <0.00%> (+2.00%)
...pendistroforelasticsearch/ad/cluster/HashRing.java 84.21% <0.00%> (+5.26%) 11.00% <0.00%> (+1.00%)

@yizheliu-amazon yizheliu-amazon added the bug Something isn't working label Mar 10, 2021
@@ -4,10 +4,12 @@ on:
branches:
- main
- opendistro-*
- 7.10.2-no-workbench
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may not need this in main branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, does not hurt :)

@kaituo kaituo merged commit 09eebb5 into opendistro-for-elasticsearch:main Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants