This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding support for Security Test Framework #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saratvemulapalli
requested review from
ylwu-amzn,
yizheliu-amazon and
weicongs-amazon
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
============================================
+ Coverage 73.66% 75.51% +1.84%
- Complexity 2022 2159 +137
============================================
Files 201 207 +6
Lines 9664 10030 +366
Branches 860 898 +38
============================================
+ Hits 7119 7574 +455
+ Misses 2112 2034 -78
+ Partials 433 422 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
yizheliu-amazon
approved these changes
Dec 15, 2020
src/test/java/com/amazon/opendistroforelasticsearch/ad/rest/SecureADRestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/ad/rest/SecureADRestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/ad/rest/SecureADRestIT.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Dec 16, 2020
src/test/java/com/amazon/opendistroforelasticsearch/ad/rest/SecureADRestIT.java
Show resolved
Hide resolved
Sure this already runs as part of the CI today, we are just adding a full new suite of tests. |
weicongs-amazon
approved these changes
Dec 17, 2020
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Adding support for Security Test Framework * Excluding secure tests when not running against security plugin * Updating Delete Detector test to expect exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #195 *
Description of changes:
Adding support for Security tests for AD.
These tests will be run as part of CI and also can be locally tested with a test cluster.
Running locally:
-Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" -Dhttps=true -Duser=admin -Dpassword=admin --tests "com.amazon.opendistroforelasticsearch.ad.rest.SecureADRestIT.*"By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.