Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Injecting User role for background job #295

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

saratvemulapalli
Copy link
Contributor

@saratvemulapalli saratvemulapalli commented Oct 26, 2020

*Issue #195 *

Description of changes:
Adding User role injection to AD background job runner

The changes are manually tested on a test domain.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #295 into master will decrease coverage by 0.09%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #295      +/-   ##
============================================
- Coverage     71.16%   71.06%   -0.10%     
+ Complexity     1874     1873       -1     
============================================
  Files           195      195              
  Lines          9056     9063       +7     
  Branches        765      766       +1     
============================================
- Hits           6445     6441       -4     
- Misses         2245     2255      +10     
- Partials        366      367       +1     
Flag Coverage Δ Complexity Δ
#cli 79.27% <ø> (ø) 0.00 <ø> (ø)
#plugin 70.36% <57.14%> (-0.11%) 1873.00 <0.00> (-1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oforelasticsearch/ad/AnomalyDetectorJobRunner.java 75.00% <57.14%> (-0.64%) 36.00 <0.00> (ø)
...port/SearchAnomalyDetectorInfoTransportAction.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (ø%)
...ransport/DeleteAnomalyDetectorTransportAction.java 53.40% <0.00%> (-4.55%) 15.00% <0.00%> (-1.00%)

@kaituo
Copy link
Member

kaituo commented Oct 27, 2020

Looks good. Build is failing.

@saratvemulapalli
Copy link
Contributor Author

Looks good. Build is failing.

Thanks Kaituo for taking a look.
Fixed the tests as well.

@saratvemulapalli saratvemulapalli merged commit 5093c8a into master Oct 27, 2020
@saratvemulapalli saratvemulapalli deleted the fgac-secure-adrunner branch October 27, 2020 01:11
@ylwu-amzn ylwu-amzn added the bug Something isn't working label Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants