Adding RestActions support for AD Search Rest API's

[saratvemulapalli]

Adding RestActions support for Search Rest API's.

• This is needed to integrate with Security plugin as it applies permissions based on Rest Actions.
• This is the first of the API's and work in progress for other APIs. Tests will be added soon.
  *Issue Anomaly Detection integration with Security : FGAC Support #195 *

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

Merging #234 into master will decrease coverage by 0.28%.
The diff coverage is 96.55%.

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     72.25%   71.97%   -0.29%     
- Complexity     1278     1284       +6     
============================================
  Files           139      143       +4     
  Lines          6045     5980      -65     
  Branches        469      469              
============================================
- Hits           4368     4304      -64     
+ Misses         1465     1462       -3     
- Partials        212      214       +2     

Flag	Coverage Δ	Complexity Δ
#cli	78.11% <ø> (-2.20%)	0.00 <ø> (ø)
#plugin	71.25% <96.55%> (+0.07%)	1284.00 <8.00> (+6.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java	93.54% <ø> (ø)	10.00 <0.00> (ø)
...forelasticsearch/ad/rest/AbstractSearchAction.java	25.00% <66.66%> (+2.41%)	2.00 <0.00> (ø)
...earch/ad/rest/RestSearchAnomalyDetectorAction.java	100.00% <100.00%> (ø)	2.00 <0.00> (ø)
...csearch/ad/rest/RestSearchAnomalyResultAction.java	100.00% <100.00%> (ø)	2.00 <0.00> (ø)
...arch/ad/transport/SearchAnomalyDetectorAction.java	100.00% <100.00%> (ø)	2.00 <2.00> (?)
...ransport/SearchAnomalyDetectorTransportAction.java	100.00% <100.00%> (ø)	2.00 <2.00> (?)
...search/ad/transport/SearchAnomalyResultAction.java	100.00% <100.00%> (ø)	2.00 <2.00> (?)
.../transport/SearchAnomalyResultTransportAction.java	100.00% <100.00%> (ø)	2.00 <2.00> (?)
...asticsearch/ad/cluster/ADClusterEventListener.java	88.00% <0.00%> (-6.00%)	13.00% <0.00%> (-2.00%)
cli/internal/gateway/ad/ad.go	60.43% <0.00%> (-4.95%)	0.00% <0.00%> (ø%)
... and 9 more

[skkosuri-amzn]

Plans to add UTs?

[skkosuri-amzn]

Lets use opendistro in the action name. For example: cluster:admin/opendistro/alerting/destinations/write

Also you might want to end with verb like: cluster:admin/opendistro/ad/detectors/search

[saratvemulapalli]

Sure that makes sense.
Will make changes.

[skkosuri-amzn]

NP: your rest handler is called : RestSearchAnomalyDetectorAction, Would it be better to call transport handler as TransportSearchAnomalyDetectorAction

[saratvemulapalli]

Thats a good point. Existing Transport Actions were named that way, so I just followed them to be consistent.
Here are some examples:https://github.com/opendistro-for-elasticsearch/anomaly-detection/tree/master/src/main/java/com/amazon/opendistroforelasticsearch/ad/transport

[kaituo]

Looks good overall. Will wait for your tests.

[saratvemulapalli]

Plans to add UTs?

Thanks for taking a look. Yup will send them out today.

[saratvemulapalli]

Looks good overall. Will wait for your tests.

Cool, thanks for taking a look. Yup I'll send out the tests today.