This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Update README.md #222
Merged
Update README.md #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add installation steps from binaries
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 72.41% 72.43% +0.01%
- Complexity 1290 1291 +1
============================================
Files 139 139
Lines 6073 6073
Branches 469 469
============================================
+ Hits 4398 4399 +1
Misses 1464 1464
+ Partials 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Use version flag to check version
kaituo
approved these changes
Sep 3, 2020
ylwu-amzn
reviewed
Sep 4, 2020
cli/README.md
Outdated
| sudo mv ./esad /usr/local/bin/esad | ||
|
|
||
| ``` | ||
| 4. Test to ensure the version you installed is up-to-date: |
There was a problem hiding this comment.
Do we show the version is update to date or not with command esad --version ? Or we just show version info, user need to figure out by themselves?
There was a problem hiding this comment.
I updated the step now. Can you review it again?
ylwu-amzn
reviewed
Sep 4, 2020
| ``` | ||
| 3. Move the binary in to your PATH. | ||
| ``` | ||
| sudo mv ./esad /usr/local/bin/esad |
There was a problem hiding this comment.
This requires user have enough permission to move esad to local bin folder. How about add another option for user who has no sudo permission? Will be a blocker for some user if AD CLI must need sudo permission.
Add instruction for non-sudo users.
ylwu-amzn
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add installation steps from binaries
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.