This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add async implementation of getFeaturesForPeriod. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
reviewed
Jan 15, 2020
| */ | ||
| public void getFeaturesForPeriod(AnomalyDetector detector, long startTime, long endTime, ActionListener<Optional<double[]>> listener) { | ||
| SearchRequest searchRequest = createFeatureSearchRequest(detector, startTime, endTime, Optional.empty()); | ||
| client.search(searchRequest, ActionListener.wrap( |
There was a problem hiding this comment.
Please use ClientUtil so that we have a consistent place to control index access.
There was a problem hiding this comment.
For the sake of transparency, what control is needed for this search query?
kaituo
approved these changes
Feb 19, 2020
ylwu-amzn
reviewed
Feb 20, 2020
| * @param endTime end time of the data point in epoch milliseconds | ||
| * @param listener onResponse is called with unprocessed features and processed features for the current data point | ||
| */ | ||
| public void getCurrentFeatures(AnomalyDetector detector, long startTime, long endTime, ActionListener<SinglePointFeatures> listener) { |
There was a problem hiding this comment.
Can you replace the deprecated getCurrentFeatures method with this one ?
There was a problem hiding this comment.
Rewriting caller code will be a much larger change in a separate pr.
ylwu-amzn
approved these changes
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the asynchronous implementation of getFeaturesForPeriod without business logic changes to deprecate the current synchronous implementation.