Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hansbug): fix bug of #82, add more unittests #83

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

HansBug
Copy link
Member

@HansBug HansBug commented Mar 6, 2023

Description

see #82

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@HansBug HansBug added the bug Something isn't working label Mar 6, 2023
@HansBug HansBug self-assigned this Mar 6, 2023
@HansBug HansBug linked an issue Mar 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #83 (80d4e9b) into main (15debc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          43       43           
  Lines        2723     2726    +3     
=======================================
+ Hits         2696     2699    +3     
  Misses         27       27           
Flag Coverage Δ
unittests 99.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
treevalue/tree/func/cfunc.pyx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HansBug HansBug requested a review from PaParaZz1 March 6, 2023 08:37
@HansBug HansBug merged commit 947e137 into main Mar 6, 2023
@HansBug HansBug deleted the fix/treelize branch March 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When function returns a treevalue
2 participants