Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(hansbug): add delay feature in treevalue && add mode and missing option to union and subside #23

Merged
merged 29 commits into from
Jan 4, 2022

Conversation

HansBug
Copy link
Member

@HansBug HansBug commented Dec 30, 2021

Description

  • Add basic delay feature in treevalue
  • Add delay into func_treelize
  • Add delay into subside and union
  • Add mode and missing option to union and subside

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@HansBug HansBug added the enhancement New feature or request label Dec 30, 2021
@HansBug HansBug added this to the v1.2.0 Release milestone Dec 30, 2021
@HansBug HansBug self-assigned this Dec 30, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #23 (17c2ac4) into main (f5bd4fc) will increase coverage by 0.01%.
The diff coverage is 99.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   99.19%   99.20%   +0.01%     
==========================================
  Files          34       35       +1     
  Lines        1861     2013     +152     
==========================================
+ Hits         1846     1997     +151     
- Misses         15       16       +1     
Flag Coverage Δ
unittests 99.20% <99.53%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
treevalue/tree/common/delay.pyx 97.67% <97.67%> (ø)
treevalue/tree/common/__init__.py 100.00% <100.00%> (ø)
treevalue/tree/common/base.pyx 100.00% <100.00%> (ø)
treevalue/tree/common/storage.pyx 100.00% <100.00%> (ø)
treevalue/tree/func/cfunc.pyx 100.00% <100.00%> (ø)
treevalue/tree/func/func.py 100.00% <100.00%> (ø)
treevalue/tree/general/general.py 100.00% <100.00%> (ø)
treevalue/tree/tree/__init__.py 100.00% <100.00%> (ø)
treevalue/tree/tree/flatten.pyx 100.00% <100.00%> (ø)
treevalue/tree/tree/functional.pyx 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bd4fc...17c2ac4. Read the comment docs.

@HansBug HansBug requested a review from PaParaZz1 January 3, 2022 11:37
@HansBug HansBug merged commit 7a627e8 into main Jan 4, 2022
@HansBug HansBug deleted the dev/delay branch January 4, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants