Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(zjow): add agent class to support LightZero's HuggingFace Model Zoo #163
feature(zjow): add agent class to support LightZero's HuggingFace Model Zoo #163
Changes from 2 commits
20f3cfb
9c50524
f36751c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的config是专门用于新写的 muzero class的config吗?以后所有的config相当于都需要再这里重写一份,应该可以写一个转换函数,把LZ原来的config转换成这里需要格式的config,然后就可以避免冗余代码了吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我不太推荐写个转换函数,最好是代码里写的就是Agent load的,这样比较直接。(以后如果不用这一些config了,删了就算废弃了,不会牵扯到其它组件。)(如果写转换函数的话,我对未来的兼容性承诺保持怀疑。而且不易读。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的哈