dev(hansbug): better docker builder and launcher#45
Draft
HansBug wants to merge 3 commits intoopendilab:mainfrom
Draft
dev(hansbug): better docker builder and launcher#45HansBug wants to merge 3 commits intoopendilab:mainfrom
HansBug wants to merge 3 commits intoopendilab:mainfrom
Conversation
PaParaZz1
requested changes
Feb 22, 2026
| # dbuild: build docker image with cache if exists | ||
| dbuild: | ||
| docker build -t ${IMAGE_NAME} . | ||
| if docker image inspect ${IMAGE_NAME} >/dev/null 2>&1; then \ |
Member
There was a problem hiding this comment.
add comment for this if-branch
| 0 | ||
| """ | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("-i", "--input", dest="volume_str") |
Member
There was a problem hiding this comment.
should we add volume_str by add_argument function here
|
|
||
| volume_str = args.volume_str or os.environ.get("DOCKER_VOLUME_STR", "") | ||
| if not volume_str: | ||
| return 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All in Makefile