feature(zjow): add middleware for ape-x structure pipeline #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaParaZz1
added
the
efficiency optimization
zjowowen
changed the title
PaParaZz1
requested changes
Aug 7, 2023
| @@ -54,7 +54,10 @@ def __init__( | |||
|
|
|||
| def push(self, chain: Callable, data: Any, meta: Optional[dict] = None, *args, **kwargs) -> BufferedData: | |||
| if meta is None: | |||
| meta = {'priority': self.max_priority} | |||
| if 'priority' in data: | |||
| meta = {'priority': data['priority'].item()} | |||
There was a problem hiding this comment.
do item operation in original priority producer
| meta = {'priority': self.max_priority} | ||
| if 'priority' in data: | ||
| meta = {'priority': data['priority'].item()} | ||
| else: |
There was a problem hiding this comment.
add unittest for this new if-else branch
| Parallel.runner(n_parallel_workers=2, startup_interval=0)(periodical_model_exchanger_main) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
unittest doesn't need this entry
|
|
||
| priority = func_for_priority_calculation(ctx.trajectories) | ||
| for i in range(len(priority)): | ||
| ctx.trajectories[i]['priority'] = torch.tensor(priority[i], dtype=torch.float32).unsqueeze(-1) |
|
|
||
| def _priority_calculator(ctx: "OnlineRLContext") -> None: | ||
|
|
||
| priority = func_for_priority_calculation(ctx.trajectories) |
| from ding.framework import OnlineRLContext | ||
|
|
||
|
|
||
| def priority_calculator(func_for_priority_calculation: Callable) -> Callable: |
| self._model_loader = model_loader | ||
| self._event_name = event_name | ||
| self._period = period | ||
| self.mode = mode |
|
|
||
| def _cache_state_dict(self, msg: Dict[str, Any]): | ||
| # msg: Dict {'id':id,'model':state_dict: Union[object, Storage]} | ||
| print(f"node_id[{task.router.node_id}] get model msg") |
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 82.06% 80.79% -1.27%
==========================================
Files 586 597 +11
Lines 47515 49631 +2116
==========================================
+ Hits 38991 40101 +1110
- Misses 8524 9530 +1006
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PaParaZz1
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add middleware priority_calculator for calculate priority in collector.
Add middleware PeriodicalModelExchanger for better control model send and receive process.