feature(zlx): add envpool #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciusMos
added
efficiency optimization
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 86.07% 85.95% -0.13%
==========================================
Files 464 466 +2
Lines 35872 35923 +51
==========================================
- Hits 30878 30876 -2
- Misses 4994 5047 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PaParaZz1
requested changes
Mar 15, 2022
| @@ -0,0 +1,151 @@ | |||
| import os | |||
There was a problem hiding this comment.
merge envpool_dqn_main.py into atari_dqn_main.py, use different config options to control which env manager is used.
There was a problem hiding this comment.
Preserve pong_dqn_envpool_main because envpool env manager is slightly different from others.
LuciusMos
force-pushed
the
dev-envpool
branch
2 times, most recently
from
03a9f62
to
d75fe87
Compare
LuciusMos
force-pushed
the
dev-envpool
branch
3 times, most recently
from
223624b
to
7a8e3ae
Compare
…anager, reset returns until all envs are reset successfully
PaParaZz1
approved these changes
Mar 17, 2022
puyuan1996
pushed a commit
to puyuan1996/DI-engine
that referenced
this pull request
Apr 18, 2022
* feature(nyz): init envpool(ci skip) * feature(nyz): add naive envpool atari demo * fix(nyz): fix typo and unused import * feature(zlx): Modify envpool config * fixbug(zlx): Fix comments by nyz * fixbug(zlx): add unittest for envpool env manager * style(zlx) * fixbug(zlx): Add runtime installation of envpool * fixbug(zlx): Add pip install envpool in github unittest workflows * fixbug(zlx): Add pip install envpool in github unittest workflows * test(zlx): Seperate envpool test out of unit/platform test * fixbug(zlx): Withdraw changes in sample serial collector; In PoolEnvManager, reset returns until all envs are reset successfully Co-authored-by: niuyazhe <niuyazhe@sensetime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
TODO
Check List