Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@tjohnson31415
Copy link

Set VLLM_ALLOW_LONG_MAX_MODEL_LEN=1 in the UBI docker build to have it enabled by default. This allows the operator to specify a --max-model-len that exceeds the value parsed from the model's config.json. A warning will still be printed, but the server will not crash.

See: vllm-project#7080

@tjohnson31415
Copy link
Author

Tests failed due to a requirements file missing from the docker build mounts... unrelated to the change in this PR:

ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements-adag.txt'
error: build error: building at STEP "RUN --mount=type=cache,target=/root/.cache/pip --mount=type=bind,source=requirements-common.txt,target=requirements-common.txt --mount=type=bind,source=requirements-cuda.txt,target=requirements-cuda.txt --mount=type=bind,source=requirements-dev.txt,target=requirements-dev.txt --mount=type=bind,source=requirements-lint.txt,target=requirements-lint.txt --mount=type=bind,source=requirements-test.txt,target=requirements-test.txt pip3 install         -r requirements-cuda.txt         -r requirements-dev.txt": while running runtime: exit status 1

@dtrifiro
Copy link

This is going to pass after #122 is merged

@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2024

New changes are detected. LGTM label has been removed.

@tjohnson31415 tjohnson31415 force-pushed the allow-long-max-length branch from d2f43c6 to a6cf3da Compare August 14, 2024 14:51
@dtrifiro dtrifiro force-pushed the allow-long-max-length branch from a6cf3da to 936e400 Compare August 19, 2024 09:27
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
@tjohnson31415 tjohnson31415 force-pushed the allow-long-max-length branch from 936e400 to 49f5b01 Compare August 20, 2024 15:49
@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjohnson31415
Once this PR has been reviewed and has the lgtm label, please assign rh-steve-grubb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2024

@tjohnson31415: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 936e400ad71e802ae5e69e7bd062377f1d1a6619 link true /test smoke-test
ci/prow/images 49f5b01 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro dtrifiro merged commit 204a1d4 into main Aug 20, 2024
@dtrifiro dtrifiro deleted the allow-long-max-length branch August 20, 2024 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants