Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@dtrifiro
Copy link

@dtrifiro dtrifiro commented Aug 6, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from Xaenalt and njhill August 6, 2024 09:03
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
@dtrifiro dtrifiro mentioned this pull request Aug 6, 2024
@dtrifiro dtrifiro added the lgtm label Aug 6, 2024
@dtrifiro
Copy link
Author

dtrifiro commented Aug 6, 2024

Requires #122

@openshift-ci openshift-ci bot removed the lgtm label Aug 6, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test e475be0 link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro
Copy link
Author

dtrifiro commented Aug 7, 2024

Waiting on a vllm-tgis-adapter release opendatahub-io/vllm-tgis-adapter#82

@dtrifiro
Copy link
Author

Waiting on #126

@dtrifiro
Copy link
Author

Moved to #127

@dtrifiro dtrifiro closed this Aug 13, 2024
@dtrifiro dtrifiro deleted the bump-flashinfer branch August 13, 2024 14:34
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
* Initial implementation of chat/completions endpoint and its streaming variant

* Reusing datatypes from the openai entrypoints

* Response role from arg

* Added models endpoint and model validation from the request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant