Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass param for pre-created socket to uvicorn #224

Closed
wants to merge 2 commits into from
Closed

Pass param for pre-created socket to uvicorn #224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81deb93
add sock=NONE param due PR #13113
fialhocoelho Feb 15, 2025
9526282
Keep fn backwards compatible with 0.7.2
fialhocoelho Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Keep fn backwards compatible with 0.7.2 
Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com>
  • Loading branch information
@fialhocoelho @dtrifiro
fialhocoelho and dtrifiro authored Feb 21, 2025
commit 9526282cb358c1279e5b7d9e301d0bae143ae89a
7 changes: 6 additions & 1 deletion src/vllm_tgis_adapter/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ async def set_correlation_id(request: Request, call_next: Callable) -> Response:
}
serve_kwargs.update(uvicorn_kwargs)

shutdown_coro = await serve_http(app, sock=None, **serve_kwargs)
from vllm.version import __version_tuple__ as vllm_version_tuple
...
if vllm_version_tuple >= (0, 7, 3):
serve_kargs['sock'] = None

shutdown_coro = await serve_http(app, **serve_kwargs)

# launcher.serve_http returns a shutdown coroutine to await
# (The double await is intentional)
Expand Down
Loading