Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: exclude file which auto-gen by "make" checkin #1084

Merged
merged 1 commit into from
Jun 26, 2024
Merged

chore: exclude file which auto-gen by "make" checkin #1084

merged 1 commit into from
Jun 26, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jun 26, 2024

Description

seems some IDE would auto checkin files or maybe a "git add ." does so, but config/manager/kustomization.yaml is not intended to be store in git repo

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw
chore: exclude file which auto-gen by "make" checkin
2d5e713 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw requested review from bartoszmajsak and ykaliuta and removed request for ajaypratap003 and VaishnaviHire June 26, 2024 07:13
@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AjayJagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 65f9522 into opendatahub-io:incubation Jun 26, 2024
4 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 24, 2024
@zdtsw @VaishnaviHire
chore: exclude file which auto-gen by "make" checkin (opendatahub-io#…
e39a869 
…1084)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 65f9522)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 24, 2024
@zdtsw @VaishnaviHire
chore: exclude file which auto-gen by "make" checkin (opendatahub-io#…
5110f1f 
…1084)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 65f9522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AjayJagan AjayJagan AjayJagan approved these changes

@bartoszmajsak bartoszmajsak Awaiting requested review from bartoszmajsak

@ykaliuta ykaliuta Awaiting requested review from ykaliuta

Assignees

@AjayJagan AjayJagan

Labels
approved lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @AjayJagan