-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add secure mysql db samples, fixes RHOAIENG-5436 #95
Conversation
@nehachopra27 @tonyxrmdavidson we should use these secure mysql samples in QE tests as that's closer to what users will deploy in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I notice there is some little mods to pgsql but I believe those are fine too thanks!
Both could be just documentation details but be good to note for the users. |
Good ideas, I'll add them to the readme. In general, these are just samples and users are not expected to use these exact DB configurations in production. The secure DB samples are there to test and demo model registry support for secure DB connections. |
Description
Added secure mysql db samples without and with istio tls
Fixes RHOAIENG-5436
Fixes RHOAIENG-6713
How Has This Been Tested?
Tested samples manually, by first creating the DB cert using
make certificates
and then the appropriatekubectl apply -k
command.Merge criteria: