Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secure mysql db samples, fixes RHOAIENG-5436 #95

Merged
merged 3 commits into from
May 6, 2024

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented May 3, 2024

Description

Added secure mysql db samples without and with istio tls
Fixes RHOAIENG-5436
Fixes RHOAIENG-6713

How Has This Been Tested?

Tested samples manually, by first creating the DB cert using make certificates and then the appropriate kubectl apply -k command.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb
Copy link
Contributor Author

dhirajsb commented May 3, 2024

@nehachopra27 @tonyxrmdavidson we should use these secure mysql samples in QE tests as that's closer to what users will deploy in production.

tarilabs
tarilabs previously approved these changes May 3, 2024
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I notice there is some little mods to pgsql but I believe those are fine too thanks!

isinyaaa
isinyaaa previously approved these changes May 3, 2024
@rareddy
Copy link
Contributor

rareddy commented May 3, 2024

  1. Is there a procedure to update or rotate the certificates when they expire?
  2. Is there a procedure for a user to bring in their custom certificates instead of self-generated?

Both could be just documentation details but be good to note for the users.

@dhirajsb
Copy link
Contributor Author

dhirajsb commented May 3, 2024

Is there a procedure to update or rotate the certificates when they expire?
Is there a procedure for a user to bring in their custom certificates instead of self-generated?

Good ideas, I'll add them to the readme. In general, these are just samples and users are not expected to use these exact DB configurations in production. The secure DB samples are there to test and demo model registry support for secure DB connections.

@dhirajsb dhirajsb dismissed stale reviews from isinyaaa and tarilabs via f200617 May 3, 2024 15:50
@dhirajsb dhirajsb merged commit 73e149f into opendatahub-io:main May 6, 2024
2 checks passed
@dhirajsb dhirajsb deleted the feat/secure-mysql branch May 6, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants