Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL SSL connection options, resolves #16 #35

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

dhirajsb
Copy link
Contributor

Description

Added CR properties to configure cert, key, key password, and CA certs for PostgreSQL SSL connection.
Resolves #16

How Has This Been Tested?

Tested configuration manually by creating secrets and setting the SSL properties manually.
However, mlmd Docker image has an issue with creating a PostgreSQL SSL connection,
See: google/ml-metadata#187

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb merged commit 34de95b into opendatahub-io:main Nov 22, 2023
2 checks passed
@dhirajsb dhirajsb deleted the pg-ssl branch November 22, 2023 16:58
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this enables custom certs for ssl connection to Postgresql.

Thank you!

required:
- key
- name
type: object
sslMode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If sslMode=required is not working, would it make sense to not have it in our options (adding comment to upstream https://github.com/google/ml-metadata/issues/187#issue-2005410819 issue?)

I understand that is orthogonal to this PR scope, just noticed thought about mentioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for secure SSL PostgreSQL connections
2 participants