Skip to content

Commit

Permalink
chore: switch from pipenv to uv
Browse files Browse the repository at this point in the history
uv from the people who wrote ruff is an extremely fast Python package
and project manager.

Signed-off-by: Sébastien Han <seb@redhat.com>
  • Loading branch information
leseb committed Dec 10, 2024
1 parent 8c2981c commit 17c387d
Show file tree
Hide file tree
Showing 7 changed files with 674 additions and 668 deletions.
16 changes: 5 additions & 11 deletions .github/workflows/pre_commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,10 @@ jobs:
with:
fetch-depth: 2 # Needed for HEAD to exists

- name: Setup Python
uses: actions/setup-python@v5
- name: Install uv
uses: astral-sh/setup-uv@v4
with:
python-version: "3.12"
cache: pipenv

- name: Setup Pipenv
uses: tiagovrtr/actions-pipenv@v1
with:
pipenv-version: "v2024.1.0"

- name: Configure caching
uses: actions/cache@v4
Expand All @@ -37,15 +31,15 @@ jobs:

- name: Install dependencies
run: |
pipenv sync
uv sync
- name: Run pre-commit
run: |
pipenv run pre-commit run --all-files
uv run pre-commit run --all-files
- name: Test if pipeline is up-to-date
run: |
pipenv run make pipeline
uv run make pipeline
git diff --exit-code || (echo "Pipeline is not up-to-date. Please run 'make pipeline' and commit the changes." && exit 1)
- name: test if standalone.py was updated and not standalone.tpl (no components file(s) updated)
Expand Down
1 change: 1 addition & 0 deletions .python-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.12
18 changes: 0 additions & 18 deletions Pipfile

This file was deleted.

639 changes: 0 additions & 639 deletions Pipfile.lock

This file was deleted.

13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,16 @@ To generate the `standalone.py` script, run the following command ([ruff](https:
```bash
make standalone
```

## Developer setup

To collaborate on this repository, please follow these steps:

1. Install [uv](https://docs.astral.sh/uv/getting-started/installation/)
2. Run following commands to prepare your local environment

```bash
uv sync
uv venv
source .venv/bin/activate
```
15 changes: 15 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
[project]
name = "ilab-on-ocp"
version = "0.1.0"
description = "Run the iLab workflow on RHOAI"
readme = "README.md"
requires-python = ">=3.12"
dependencies = [
"click>=8.1.7",
"jinja2>=3.1.4",
"kfp-kubernetes>=1.4.0",
"kfp==2.9.0",
"kubernetes==30.1.0",
"pre-commit>=4.0.1",
"ruff>=0.8.2",
]
640 changes: 640 additions & 0 deletions uv.lock

Large diffs are not rendered by default.

0 comments on commit 17c387d

Please sign in to comment.