UPSTREAM: <carry>: Reworded logs to indicate non-critical issues and … #67
Conversation
Commit Checker results: |
|
A set of new images have been built to help with testing out this PR: |
|
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-67
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-67"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-67"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-67"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-67"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-67"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-67"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'Then run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/67/head
git checkout -b pullrequest 332712fbb95e9b69bad2b40bc72d28c85866f179
oc apply -f dspa.pr-67.yamlMore instructions here on how to deploy and test a Data Science Pipelines Application. |
backend/src/apiserver/client/swf.go
Outdated
| @@ -61,7 +61,7 @@ func NewScheduledWorkflowClientOrFatal(initConnectionTimeout time.Duration, clie | |||
| if err == nil { | |||
| return swfClientInstance | |||
| } | |||
| glog.Infof("(Expected when in cluster) Failed to create scheduled workflow client by out of cluster kubeconfig. Error: %v", err) | |||
| glog.Infof("Non-critical error: Failed to create scheduled workflow client by out of cluster kubeconfig. This can be safely ignored if running in-cluster.Error: %v", err) | |||
There was a problem hiding this comment.
I would just delete this line. I don't see the point of it.
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
…provide informational context Signed-off-by: vmudadla <vmudadla@redhat.com>
Commit Checker results: |
VaniHaripriya
force-pushed
the
RHOAIENG-6710
branch
from
250cff4
to
3fe6837
Compare
|
/lgtm thanks! |
Commit Checker results: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gregsheremeta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a8fbbd2
into
opendatahub-io:master
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
1 similar comment
|
Change to PR detected. A new PR build was completed. |
Resolves RHOAIENG-6710
Updated some log messages in DSP server to clearly convey that the reported issues are non-critical and intended for informational purposes only, helping users understand that these messages do not require immediate action.