-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3… #60
Revert "UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3… #60
Conversation
… from v3.3.10 to v3.5.8" This reverts commit 38ce527.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/Approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ed99781
into
opendatahub-io:master
Commit Checker results:
|
1 similar comment
Commit Checker results:
|
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-60
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-60"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-60"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-60"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-60"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-60"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-60"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/60/head
git checkout -b pullrequest eb9b96cf5d76f553c7f42f0fee3e32534082633f
oc apply -f dspa.pr-60.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
… from v3.3.10 to v3.5.8"
This reverts commit 38ce527.
cc @DharmitD @gregsheremeta @gmfrasca