-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated envoy and grpc image URLs for bot #25
chore: Updated envoy and grpc image URLs for bot #25
Conversation
…mages. Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-25
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-25"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-25"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-25"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-25"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-25"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-25"
envoy:
image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-25"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-25"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/25/head
git checkout -b pullrequest ff2f239453fc314e76e269b50a5cab6d623ba9c9
oc apply -f dspa.pr-25.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e89b60
into
opendatahub-io:master
@amadhusu @rimolive are you sure the GRPC one is correct? Pulling and starting gives me an error:
|
Well, it should: https://quay.io/repository/opendatahub/model-registry/tag/latest |
Fix: #26 |
Description of your changes:
Updated envoy and grpc image URLs for bot to comment on PRs.
Checklist: