Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fixes "cannot save parameter" error message. Fixes #9678 (#10459) #20

Conversation

hbelmiro
Copy link

@hbelmiro hbelmiro commented Feb 22, 2024

Resolves https://issues.redhat.com/browse/RHOAIENG-1629

Cherry picked from kubeflow#10459

How to test

Deploy and run https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/config/samples/v2/dspa-simple/dspa_simple.yaml with the quay.io/opendatahub/ds-pipelines-driver:pr-20 driver image.

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: sample
spec:
  dspVersion: v2
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'
  mlpipelineUI:
    image: quay.io/opendatahub/ds-pipelines-frontend:latest
  apiServer:
    argoDriverImage: quay.io/opendatahub/ds-pipelines-driver:pr-20

…flow#9678 (kubeflow#10459)

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
(cherry picked from commit 1ae0a82)
@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-20
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-20
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-20
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-20
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-20
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-20
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-20
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-20

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-20.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-20
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-20"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-20"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-20"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-20"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-20"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-20"
    envoy:
      image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-20"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-20"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/20/head
git checkout -b pullrequest 90a92f9394cf04df339c3e3775cf621b78c65f22
oc apply -f dspa.pr-20.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro marked this pull request as ready for review February 22, 2024 19:36
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gregsheremeta
Copy link

/lgtm

/approve

Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c9916af into opendatahub-io:master Feb 22, 2024
2 checks passed
@hbelmiro hbelmiro deleted the cherry-pick-cannot-save-parameters branch February 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants