Add Neo4j index extension CIP #197
Conversation
Mats-SX
force-pushed
the
neo4j-indexes
branch
2 times, most recently
from
394c1cb
to
7e54204
Compare
- General outline - Describe the node uniqueness constraint
- Define domain for uniqueness - Define domain for existence
- Use hex integers for rgb examples
- Specify general constraint language - Specify `UNIQUE` operator - Clearly define semantics for domain and expressions - List all concrete constraints in example section - Add several more examples
They are more appropriate under the Semantics and Syntax sections, respectively.
Move Errors section
References opencypher#172
- Remove TODO - Add example using larger pattern - Add example using multiple `exists()`
- Rename `constrait-expr` to `constraint-predicate` - Limit scope of `UNIQUE` to single properties only - Update examples to reflect `PRIMARY KEY`
- Remove erroneous example for composing `NODE KEY` with `UNIQUE` and `exists()` - Rephrase example section to describe `NODE KEY` more accurately.
- Add missing case for when an error should be raised
Add test for DROP
- NODE KEY not PRIMARY KEY - Reference to constraints syntax - Properly define domain - Expanded example to explain domain definition and consequences - Error cases - Add names to examples
|
This CIP is now also ready for review. It builds on top of #166 so there's no need to review changes that come from that PR here. The reason to build it on top is because this CIP makes many references to the general Constraint Syntax CIP. |
|
I have some questions:
|
|
CLG review finds on @sherfert's points:
|
|
From LangStar review:
|
This reflects a Neo4j extension of the constraints syntax suggested in #166 to support index creation/deletion.
Direct link to CIP