BugFix: Fix & enhance DAISY sampling from convoluted cubes collection. - #503
Merged
Conversation
Contributor
Author
|
PR should include: opencv/opencv_extra#285 regression data. |
Member
|
👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jan 14, 2016
allnes
pushed a commit
to allnes/opencv_contrib
that referenced
this pull request
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address:
(1) BugFix: Fix descriptor sampling in interpolated mode over convoluted collection of cubes. Sampling should be done properly over the convoluted cubes.
(2) Enhancement: Original, and actual
compute_histograms()was ment to convert (h,y,x) to (y,x,h) for the descriptor sampler part. The(h,y,x)data order was used to perform inplace stacked convolutions (first one time) but then the(y,x,h)order is useful to do fast &memory aligned.ptr<float>(y,x,0)[h]like sampling for final descriptor (at any time).All my apologies for letting this latent issue so long, now DAISY should be at full and original quality.