rgbd: avoid unaligned SIMD stores in LineMOD - #4187
Open
Nikhi00718 wants to merge 1 commit into
Open
Conversation
Nikhi00718
marked this pull request as ready for review
August 10, 2026 09:10
Author
|
I reviewed the SIMD change: the aligned path is now selected only when both source and destination base addresses and row strides preserve 16-byte alignment, while unaligned loads/stores cover the fallback. The added 218-pixel, 3-channel regression targets the reported row-stride case. Native rgbd CI is still required because this host has no C++ build toolchain; please request maintainer review on the current head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29559
Testing
git diff --checkrgbdregression test is intended to run in repository CI.AI assistance disclosure
I identified and reproduced the issue, then used OpenAI Codex to assist with the implementation and regression-test work. I personally reviewed the resulting diff and ran the validation commands listed above to verify the fix. Any full-suite or local-environment limitations are documented in the validation section.