Skip to content

Conversation

lenlen
Copy link
Contributor

@lenlen lenlen commented Sep 19, 2013

Added the implementation of general tracking API, TrackerMIL and TrackerBoosting.
See opencv/opencv#1291

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we need this only line.

@kirill-korniakov
Copy link

@lenlen, thank you for patience, I think we'll soon merge the pull request :) It is properly organized in general, so it will be a valuable addition! In fact I'm ready to merge your PR, since we'll have time to clean-up everything later. But if we do this, we'll loose the possibility to comment added files, while I have a couple of questions.

  1. I've already left a couple of comments above, it would be great to hear your opinion.
  2. I was trying to build the module, but on my Mac I've got a number of build issues. Screenshot is attached, do you have any ideas? It could be an issue with my environment, but please check if you know what could be a reason. mac-build-issues
  3. Am I right that all accuracy tests will fail with "to be implemented" message? If so, this is not a recommended approach, as we do not allow failing tests in the repository. Instead, you should disable you tests, AFAIK you should rename them from TEST(Tracking_TrackerMIL, accuracy) to DISABLED_TEST(Tracking_TrackerMIL, accuracy), see the documentation for more details.
  4. Are you sure that we need all these files in the opencv_contrib/modules/tracking/include/opencv2/tracking folder? I see that you have already put some of header files to the src folder, but please double check if we can move there something else. We can always extend the provided API by moving files from src to include, but not vise versa. So, better to have the absolute minimum of public header files.
  5. Minor comment. I also see that you provide Doxygen-like comments for some of you classes. I would say this is not needed, since we're using Sphinx. Some people may say that it is not recommended, since it creates some "noise" in the header files. But I think it is OK to stay with them, may be someday we'll provide Doxygen documentation as well...

So, these are my comments. The most important ones are the build issue and failing tests. Having those fixed we can merge the PR. If you think we can update Copyrights and hide the misc folder, it would be great.

Modified Copyrights

Moved plantuml source files under doc

disabled tests

Added include of precomp.hpp
@lenlen
Copy link
Contributor Author

lenlen commented Sep 20, 2013

@kirill-kornyakov I have made some changes:

  1. I checked the copyright in all files
  2. I moved the plantuml sources under doc. In the future I'll use the plantuml extension and I'll remove the png
  3. I disabled the tests
  4. I added the include of precomp.hpp to resolve the build issue. Can you check, please?

@kirill-korniakov
Copy link

I think it is perfect now =) Absent regression and perf tests are not good, but I hope they'll be added soon.

@kirill-korniakov kirill-korniakov merged commit 46b2cb2 into opencv:master Sep 20, 2013
ArtemSkrebkov referenced this pull request in ArtemSkrebkov/opencv_contrib Oct 4, 2014
vpisarev added a commit that referenced this pull request Mar 16, 2015
vpisarev pushed a commit that referenced this pull request Apr 21, 2015
AnnKatrinBecker pushed a commit to AnnKatrinBecker/opencv_contrib that referenced this pull request May 7, 2015
* upstream/master: (40 commits)
  added missing typePtr_DualTVL1OpticalFlow
  fixed contrib code to match the HAL
  Fix build of tools with hal module
  Fix (typo) bug in soring routines.
  More detailed documentation and proper cite.
  Fix AGAST function and documentation.
  Remove deprecated RST doc.
  Adapt reg sample to changes in features detectors
  Unused header deleted
  Wrap face module with python and java
  corrected the testing data path for latentsvm detector and some typos
  Bug fix opencv#2
  Unused header
  fix already defined macro variable
  fix issue for visual studio versions which arent standarized for the c99 standard
  delete private.hpp include in sample code and corresponding documentation
  Link Correction
  Replaced CV_IMPL_PROPERTY macros in public headers
  Replaced CV_PURE_PROPERTY macros with the code
  Bug fix opencv#1
  ...
vpisarev pushed a commit that referenced this pull request Jul 8, 2015
vpisarev pushed a commit that referenced this pull request Jul 8, 2015
vpisarev pushed a commit that referenced this pull request Jul 8, 2015
vpisarev pushed a commit that referenced this pull request Jul 8, 2015
tucna added a commit to tucna/opencv_contrib that referenced this pull request Aug 20, 2015
fixes

fixed compile error and warning

Remove AGAST (for merger to upstream opencv)

wrapping remaining xfeature2d classes to scripting

added test for http://code.opencv.org/issues/3943;
replaced "const InputArray" with "InputArray" to avoid warnings about "const const _InputArray&"

added test for http://code.opencv.org/issues/3943;
replaced "const InputArray" with "InputArray" to avoid warnings about "const const _InputArray&"

adding LATCH

fixed warnings in LATCH

fixed errors

fixed warnings

fixed warnings2

fixed warnings3

fixed warnings4

fixed warnings5

added description of LATCH and fixed indentation

cleaned the code a bit

added tests and renamed LATCH

Code to grab the red lined polygon from Google Maps

added python support and completed documentation

figure update

added stdout welcome message and fixed warning

fixed warning

text enhancement

trying to fix python wrapper warning on win64

trying to solve pyhton warnings

bugfix4269 included remarks in http://answers.opencv.org/question/59293/problem-with-example-motemplcpp/

Replace tab with four space

Add rotation invariance option for BRIEF descriptor.

Fix docs and repush for buildbot.

Bug fix for feature extraction

According to CartToPolar() function documentation, result angles could be in range (0..360). To prevent index overflow this check is important.

Adding edge-aware disparity filtering

Added basic interface and demo for disparity filtering, added unoptimized fast weighted least
squares filter implementation. Current demo tests domain transform, guided and
weighted least squares filters on a dataset, measures speed and quality.

Fix for Bug 4074. This seems to be just a typo-error, because the Tesseract API can handle correctly with RGB images (double-checked and it works).

Fix for Bug opencv#3633: do away with "quads [2][3] = 255;" The four lowest bits in each quads[i][j] correspond to the 2x2 binary patterns Q_1, Q_2, Q_3 in the NM paper [1] (see in page 4 at the end of first column). Q_1 and Q_2 have four patterns, while Q_3 has only two.

added INRIA pedestrian dataset

autowbGrayworld: include+src+test+testdata+sample

Add saturation based thresholding to grayworld WB

Add basic perf tests for grayworld

Add more doxygen comments

Suppress uchar conv related warning on Windows

Apply fixes suggested by Vadim

Be more correct with int types

Remove dangling N_good++

Use cvRound to suppress Windows warnings

remove floor call

vs2010 does not know, ceil, floor, round and friends.

also, those are plain integer divisions, that do not need floor at all.

New stereo module created and added some relevant files for this module

Update README.md

made some extra changes to the modules so I receive no warnings

moved the opencv2/core/private.hpp from stereo_binary_sgbm.cpp to precomp.hpp

fix for issue opencv#195

avoid overflow in histogram access

SurfaceMatching: OpenMP indices

Fixes compiler error: "index variable in OpenMP 'for' statement must have signed integral type"

Adding confidence support and optimizing disparity filtering

DisparityWLSFilter demonstrated the best results, so I removed all the other
filters. Quality was significantly improved by adding confidence support
to the filter (left-right consistency + penalty for areas near depth discontinuities).
Filter was optimized using parallel_for_ and HAL intrinsics. Demo application was
rewritten for better compliance with OpenCV standards. Added accuracy and
performance tests. Documentation was added, as well as references to the
original papers.

added PASCAL VOC dataset

+ add KCF Tracker, initial commit, added: tutorial, trackerKCF.cpp, modified: tracker.cpp, tracker.hpp

adding the resize feature

References for KCF tracker and KCF-CN  tracker

Unified the formatting

Fixed: ROI extraction when the given ROI is out of image; made the max_patch_size to be adjustable; add the CN feature extraction method

Removing all shadowing variables, make functions to const, make the table of color-names become static

change the color-names table to const

Add a framework for choosing the descriptor

Added error message for descriptor other than GRAY

Added new line at end of file

Fixing the ColorNames table initialization

Fixed warning: conversion from double to int

Updated the support for color-names features and fixing some typos

Fixing the tabulation

Split the training coefficient into numerator and denumerator

Added the feature compression method

Fixing some indentations

Fixing some indentations

Fixing alignments

Fixing some alignments

Use Doxigen format

Remove whitespaces

Removing whitespaces in featureColorName.cpp

Add an example code for the KCF tracker

update the header in example/kcf.cpp

Updating the rectangle drawing, avoid warning from variable conversion

Added doxygen documentations

Fixing warnings

remove warnings

Fixing some warnings

TLD Fixes & Optimizations

1. TLD now have module structure
2. Made some small code optimizations
3. Fixed Ensemble Classifier according to the original paper - 10
randomized ferns
4. Added comments to most of the functions and methods

Added test on TLD Dataset

Added BSD-compatible license

Added BSD-compatible license to some files

Fixed header

Fixed build error

Fix

Fix opencv#2

Fix opencv#3

Fix opencv#4

Fixed Warnings opencv#1

Fixed Warnings opencv#2

Fixed Warnings opencv#3

Shadow Fix

Fixing whitespaces

Fixing whitespaces opencv#2

Fixing whitespaces opencv#3

Adds a first implementation of the OCRBeamSearchDecoder class using the Single Layer CNN character classifier described in Coates, Adam, et al. paper: Text detection and character recognition in scene images with unsupervised feature learning, ICDAR 2011

Add a demo program for the OCRBeamSearchDecoder class and needed data files

trailing whitespaces

fix compilation warnings

fix win64 compilation error: arrays must be defined with compile-time fixed size :)

fix doxygen warnings

Fix for opencv#278 - core dump in the case of no match results.

Modified reported poses by constraining to the number of poses found.

ulong -> size_t

fixed warnings in the tracking module

Added OCL versions of Sr and Sc functions

2-nd level of parallelization + detector remake

1. Added 2-nd level of parallelization of NN on OpenCL
2. Restructured detector - now all filters work independently:
Variance Filter->Ensemble->NN,  through "buffers"

Warnings Fix opencv#1

Fixing Warnings opencv#2

Fixing Warnings opencv#3

Fixing Warnings opencv#4

Fixing Warnings opencv#5

Fixing Warnings opencv#3

Fixing Warnings opencv#4

Fixing Warnings opencv#5

Added OCL version of "integrateAdditional" function

Whitespace Fix

Transparent API Support

Fixing Warnings

Fixed bug in LSDDetector where mask doesn't remove all undesired lines

Fixing GCC 4.9 warning

Fix memory leak bug #4420

Fix bug #4373: Error (Assertion failed in resize) when passing very elongated contours to the recognition module

make sources compile again on MSVC 2012 (VC 11) by adding round()

fix suffix that was in-compatible with MSVC 2012 (VC 11)

eliminate some warnings

use better condition for checking if compiler supports round()

fixing facerecognizer tutorials and interface

Adds createOCRHMMTransitionsTable() utility function to create a tailored language model transitions table from a given list of words (lexicon)

update to use the new createOCRHMMTransitionsTable() function, and fix program description in header comments

fix Winx64 warnings

Better CNN model for character recognition. Trained with an augmented dataset by adding translation/scale variations. Updated the croped word recognition with new class numbering (compatible with previous NM classifier).

Overload the run() method in BaseOCR class in order to adapt to different classifier callbacks. The original run() method accepts only one Mat input image, this is expected to be a binarzed image with black and white text and works both with the OCRTesseract class and the OCRHMMDecoder class when the character classifier callback works with binary images (e.g. NM). The new run() method accepts two Mat input parameters. One for the gray scale (or color) source image and the other for a binary mask where each connected component corresponds to a pre-segmented character in the input image. This way the OCRHMMDecoder is able to work with character classifiers that operate in grey scale (or color) images (e.g. a CNN).

Adds example on segmented word recognition. Shows the use of the OCRHMMDecoder with the NM and CNN default classifiers.

Minor bugfix: removes unwanted space character at the begining of recognition output strings.

Fix w64 warnings

Fix w64 warnings

Improving DisparityWLSFilter interface and adding a tutorial

Now the filter natively supports StereoBM and StereoSGBM with no
parameter tuning required. Also, now user won't need to set the ROI and
the right matcher parameters manually, it is all done in the respective
convenience factory method based on the left matcher instance. Tutorial
was added to clarify the provided example of use.

doc update
opencv-pushbot pushed a commit that referenced this pull request Aug 26, 2015
@inferrna inferrna mentioned this pull request Sep 18, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request Nov 3, 2015
opencv-pushbot pushed a commit that referenced this pull request May 24, 2016
structured_light:  python / java bindings
Auron-X added a commit to Auron-X/opencv_contrib that referenced this pull request Jun 25, 2016
Auron-X added a commit to Auron-X/opencv_contrib that referenced this pull request Aug 1, 2016
1. Added frame padding in order to handle cases where   the target is
close to borders of image
2. Reduced scale parameters for Laplace distribution
Auron-X added a commit to Auron-X/opencv_contrib that referenced this pull request Aug 15, 2016
Auron-X added a commit to Auron-X/opencv_contrib that referenced this pull request Aug 23, 2016
Auron-X added a commit to Auron-X/opencv_contrib that referenced this pull request Dec 6, 2016
savuor pushed a commit to savuor/opencv_contrib that referenced this pull request Nov 25, 2017
berak added a commit to berak/opencv_contrib that referenced this pull request Dec 23, 2017
SBCV added a commit to SBCV/opencv_contrib that referenced this pull request Mar 20, 2019
@zhanglaplace zhanglaplace mentioned this pull request Apr 6, 2021
4 tasks
bmegli pushed a commit to Extend-Robotics/opencv_contrib that referenced this pull request Jul 11, 2022
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
* Enable OpenVINO build
* Add resources
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
* Initial cuda_plugin commit

* Replaced kernels in src/kernels, add renamed and updated diagram for OperationBase (aka Operation)

* Fixed build of cuda_plugin

* Updated OperatoionBase accoring the UML diagram

* Removed old graph and node classes

* Removed unused files and added bunch of tests

* Renamed DEVICE_GPU_CUDA -> DEVICE_CUDA

* Removed ngraph/node.hpp as header leaked to nvcc compiler

* Comment unused example of code that shows how to run Executation Sequence, renamed CUDAPluginFuncTests -> CudaFuncTests and disabled some tests behaviour tests that are not supported yet

* Removed pure virtual destructor for OperationBase

Co-authored-by: Yevhen Khutornyi <yevhen.khutornyi@altran.com>
Co-authored-by: Andrii Pavliuk <apavliuk@lohika.com>
Co-authored-by: Eugene Hutorny <eugene@hutorny.in.ua>
asmorkalov pushed a commit to asmorkalov/opencv_contrib that referenced this pull request Nov 7, 2024
Added FastCV Extension code for Opencv APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants