mds: add set logicalpool status #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xu-chaojie
force-pushed
the
master
branch
2 times, most recently
from
e47fa59 to
049ebf7
Compare
wu-hanqing
reviewed
Jan 20, 2021
| @@ -103,7 +103,7 @@ class LogicalPool { | |||
| type_(PAGEFILE), | |||
| initialScatterWidth_(0), | |||
| createTime_(0), | |||
| status_(AllocateStatus::DENY), | |||
| status_(AllocateStatus::ALLOW), | |||
There was a problem hiding this comment.
这是因为当前线上的版本，logicalpool在创建时就是默认会修改为Allow
There was a problem hiding this comment.
没有DENY的测试用例吗
有，见 test/mds/topology/test_topology.cpp:1116, UpdateLogicalPoolAllocateStatus_success 这个用例
ilixiaocui
reviewed
Jan 20, 2021
| @@ -345,6 +344,7 @@ message CreateLogicalPoolRequest { | |||
| required bytes redundanceAndPlaceMentPolicy = 5; //json body | |||
| required bytes userPolicy = 6; //json body | |||
| optional uint32 scatterWidth = 7; //生成copyset依据的scatterWidth平均值 | |||
| optional AllocateStatus status = 8; | |||
There was a problem hiding this comment.
commit message中以涉及到修改的模块开头
mds: ****
proto/topology.proto
Outdated
| @@ -387,6 +387,14 @@ message ListLogicalPoolResponse { | |||
| repeated LogicalPoolInfo logicalPoolInfos = 2; | |||
| } | |||
|
|
|||
| message SetLogicalPoolRequest { | |||
| optional uint32 logicalPoolID = 1; | |||
| @@ -103,7 +103,7 @@ class LogicalPool { | |||
| type_(PAGEFILE), | |||
| initialScatterWidth_(0), | |||
| createTime_(0), | |||
| status_(AllocateStatus::DENY), | |||
| status_(AllocateStatus::ALLOW), | |||
| @@ -1086,6 +1117,51 @@ int CurvefsTools::SetChunkServer() { | |||
| return 0; | |||
| } | |||
|
|
|||
| int CurvefsTools::SetLogicalPool() { | |||
There was a problem hiding this comment.
这个工具一直都没有单元测试的，目前都是手工测试
ilixiaocui
changed the title
ilixiaocui
approved these changes
Jan 26, 2021
|
recheck |
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Signed-off-by: lucperkins <lucperkins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add allocate status when create logicalpool and add SetLogicalPool to tools
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List