-
Notifications
You must be signed in to change notification settings - Fork 526
[compile] update brpc to release1.3 version #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: fan <yfan3763@gmail.com>
recheck |
The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in |
Can you paste the error output? |
Just the echo_unix_socket_client can not connect echo_unix_socket_server. I conjecture it is my new patch error. |
@ilixiaocui, @wu-hanqing has help me to fix the test error. Now the release-1.3 version bRPC has been support unix_socket. Should we use upstream unix_socket? |
Not only the domain_unixsocket_test is fail, and many tests. More test failures can use this patch and run brpc_tests. |
How about submit the patch to bRPC? |
I think it is not a good idea. bRPC will not accept our customized patch. |
recheck |
cicheck |
@fansehep Keep on going? or any help? |
Signed-off-by: fan yfan3763@gmail.com
What problem does this PR solve?
Issue Number: #2034 (comment)
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?): some unix_socket patch test has some errors but can compile pass.
Check List