Skip to content

[compile] update brpc to release1.3 version #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fansehep
Copy link
Member

Signed-off-by: fan yfan3763@gmail.com

What problem does this PR solve?

Issue Number: #2034 (comment)

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?): some unix_socket patch test has some errors but can compile pass.

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

Signed-off-by: fan <yfan3763@gmail.com>
@ilixiaocui ilixiaocui self-requested a review November 18, 2022 01:43
@ilixiaocui
Copy link
Contributor

recheck

@fansehep
Copy link
Member Author

fansehep commented Nov 18, 2022

The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in echo_c++_unix_socket_server and echo_c++_unix_socket_client client.
It seems I do something wrong with patch.
Can the old patch author help me to fix it? I don't know more about bRPC.

@ilixiaocui
Copy link
Contributor

The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in echo_c++_unix_socket_server and echo_c++_unix_socket_client client. It seems I do something wrong with patch. Can the old patch author help me to fix it? I don't know more about bRPC.

Can you paste the error output?

@fansehep
Copy link
Member Author

The release1.3 bRPC has many large changes in some places. I just make the new patch easily. But the patch with unix_socket test is failed in echo_c++_unix_socket_server and echo_c++_unix_socket_client client. It seems I do something wrong with patch. Can the old patch author help me to fix it? I don't know more about bRPC.

Can you paste the error output?

Just the echo_unix_socket_client can not connect echo_unix_socket_server.

2022-11-18_14-11-1668752337

I conjecture it is my new patch error.

@wu-hanqing wu-hanqing self-requested a review November 18, 2022 12:38
@fansehep
Copy link
Member Author

@ilixiaocui, @wu-hanqing has help me to fix the test error. Now the release-1.3 version bRPC has been support unix_socket. Should we use upstream unix_socket?

@wuhongsong
Copy link
Contributor

@ilixiaocui @wu-hanqing

@Cyber-SiKu
Copy link
Contributor

@ilixiaocui @wuhongsong

@fansehep fansehep closed this Mar 2, 2023
@fansehep
Copy link
Member Author

Not only the domain_unixsocket_test is fail, and many tests.

More test failures can use this patch and run brpc_tests.

@legionxiong
Copy link

Not only the domain_unixsocket_test is fail, and many tests.

More test failures can use this patch and run brpc_tests.

How about submit the patch to bRPC?

@fansehep
Copy link
Member Author

Not only the domain_unixsocket_test is fail, and many tests.
More test failures can use this patch and run brpc_tests.

How about submit the patch to bRPC?

I think it is not a good idea. bRPC will not accept our customized patch.

@fansehep fansehep reopened this May 29, 2023
@fansehep
Copy link
Member Author

recheck

@Cyber-SiKu
Copy link
Contributor

cicheck

@Cyber-SiKu
Copy link
Contributor

@fansehep Keep on going? or any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants